Skip to content

check() now checks pkgdown #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

check() now checks pkgdown #2561

wants to merge 4 commits into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 20, 2024 •
edited
Loading

fix #2449

If the pkgdown config is not okay, then it errors, should it just warn?

If we decide to keep on going, we could use

tryCatch(
  pkgdown::check_pkgdown(),
  error = function(cnd) {
    warning(conditionMessage(cnd), call. = FALSE)
  }
)

Maybe this should be pkgdown_sitrep() after pkgdown 2.1 to avoid tryCatch.

Perhaps this should happen as part of document in the build pane? or check_man()?

@olivroy olivroy mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should devtools::check() also run pkgdown::check_pkgdown()?
1 participant
@olivroy